Skip to content

Conversation

@svasista-ms
Copy link
Contributor

@svasista-ms svasista-ms commented Aug 4, 2025

Closes #38

Cancels in-progress workflows/jobs for the build workflow when new events are triggered on the same branch

Summary of changes:

  • Added concurrency section to the build.yaml workflow
  • Added cancel-in-progress: true to cancel any currently running job or workflow in the same concurrency group.

@svasista-ms svasista-ms requested a review from a team August 4, 2025 12:20
@svasista-ms svasista-ms changed the title cancel in-progress build workflow cancel in-progress workflows or jobs Aug 4, 2025
@svasista-ms svasista-ms changed the title cancel in-progress workflows or jobs ci: add concurrency control to workflows Aug 5, 2025
gurry
gurry previously approved these changes Aug 12, 2025
@krishnakumar4a4
Copy link
Contributor

The build pipeline is failing due to the following error. Once it is fixed, I think this one is good to be merged.

stderr:
error: unnecessary parentheses around closure body
  --> rust-env-update.rs:21:25
   |
21 |         .map(|(key, _)| (key)),
   |                         ^   ^
   |
   = note: `-D unused-parens` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_parens)]`
help: remove these parentheses
   |
21 -         .map(|(key, _)| (key)),
21 +         .map(|(key, _)| key),
   |

@krishnakumar4a4
Copy link
Contributor

The build pipeline is failing due to the following error. Once it is fixed, I think this one is good to be merged.

stderr:
error: unnecessary parentheses around closure body
  --> rust-env-update.rs:21:25
   |
21 |         .map(|(key, _)| (key)),
   |                         ^   ^
   |
   = note: `-D unused-parens` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_parens)]`
help: remove these parentheses
   |
21 -         .map(|(key, _)| (key)),
21 +         .map(|(key, _)| key),
   |

I’ve noticed that this error originates from the wdk-build dependency. Although the fix has been merged and is available on the main branch, a release needs to be created before we can use it here.

@svasista-ms
Copy link
Contributor Author

The build pipeline is failing due to the following error. Once it is fixed, I think this one is good to be merged.

stderr:
error: unnecessary parentheses around closure body
  --> rust-env-update.rs:21:25
   |
21 |         .map(|(key, _)| (key)),
   |                         ^   ^
   |
   = note: `-D unused-parens` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_parens)]`
help: remove these parentheses
   |
21 -         .map(|(key, _)| (key)),
21 +         .map(|(key, _)| key),
   |

I’ve noticed that this error originates from the wdk-build dependency. Although the fix has been merged and is available on the main branch, a release needs to be created before we can use it here.

Yes @krishnakumar4a4, this PR can't be merged until a new version of wdk-build is published.

@svasista-ms svasista-ms dismissed stale reviews from krishnakumar4a4 and gurry via 44e6568 December 10, 2025 03:55
@svasista-ms svasista-ms requested a review from a team December 10, 2025 03:57
@gurry gurry merged commit e9a44e4 into microsoft:main Dec 12, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cancel pipelines on new push in samples repo

4 participants